Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made Bill Split Calculator responsive #1030

Merged
merged 12 commits into from
Jun 3, 2024
Merged

Made Bill Split Calculator responsive #1030

merged 12 commits into from
Jun 3, 2024

Conversation

Kashishgarg248
Copy link
Contributor

@Kashishgarg248 Kashishgarg248 commented Jun 1, 2024 •
edited by Rakesh9100
Loading

Fixes Issue🛠️

Closes #808

Description👨‍💻

Made the Bill Split Calculator responsive.

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How this has been tested✅

Tested locally.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

github-actions[bot]
github-actions bot reviewed Jun 1, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Kashishgarg248, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@netlify Netlify
Copy link

netlify bot commented Jun 1, 2024 •
edited
Loading

✅ Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 787b594
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/665dc736538dcd00082ec745
😎 Deploy Preview https://deploy-preview-1030--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rakesh9100
Copy link
Owner

Pls mention the issue number for which you have created this PR and also attach the screenshot of your work @Kashishgarg248

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Jun 1, 2024
@Rakesh9100 Rakesh9100 changed the title Added Responsiveness to Split-Bill Calculator Made Bill Split Calculator responsive Jun 1, 2024
@Kashishgarg248
Copy link
Contributor Author

Issue Number is #808
WhatsApp Image 2024-06-01 at 22 21 01_f3864f9d
Screenshot (145)

@Rakesh9100
Copy link
Owner

Why have you changed the CSS for large devices, use media queries and fix the responsiveness only for small devices properly @Kashishgarg248

@Rakesh9100 Rakesh9100 merged commit 8a0ebc9 into Rakesh9100:main Jun 3, 2024
4 checks passed
@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level1 Basic task and removed question 🤔 Further information is requested labels Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

@Kashishgarg248 Kashishgarg248

Labels
Completed 🥳 PR successfully merged and issue resolved on completion gssoc GSSOC Open Source Program level1 Basic task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Style] Make Bill Split Calculator responsive
2 participants
@Kashishgarg248 @Rakesh9100